Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map Addition Train #477

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Map Addition Train #477

wants to merge 10 commits into from
+114,405 −1

Conversation

Dunrab
Copy link
Contributor

@Dunrab Dunrab commented Jan 11, 2025 •
edited
Loading

Description

The space train! Added Train as a high pop playable map. I think this map would be a fun addition to floof since it can allow for silly admin events or just a silly time on the station it self due to it being a space train.

Added two perma job spawns, a prison guard job spawn, a golemamncer job spawn, matnis job spawn, a psych office and job spawn.

Engineering has a few means of power on this station. The AME, TEG, a tesla or a singulo so they can choose how to power the station the way they want to.

TODO

  • Add missing things for epi (such as prober and mantis jobs)
  • Spare captain ID in the captains office incase a CO needs to be elected by command
  • Make sure the four lockers are changed (bartender, jani, mime, clown)
  • Add missing things for TEG
  • Add a station anchor
  • Add the missing station pets such as seb to epi
  • Add missing station beacons
  • Mail units work
  • Make sure portals between "train cars" work
  • give parameds their hardsuit in their locker
  • Change the librarians door from service to librarian so they can open it
  • Make sure evac and arrivals dock properly
  • Add Courier job spawns and mailbox
  • Expand salv dock so the salv shuttle can dock to the train
  • Test atmos & waste to make sure both work properly
  • check the map job file to make sure the jobs match properly with the jobspawns
  • See if we can fit in a a spot for the brigmed and psych
  • decide if we want to add this to map pool or only let it be forcemapped

Media

Train-0

Changelog

🆑

  • add: Added Train as a high pop map

Dunrab added 3 commits January 11, 2025 03:45
@Dunrab
Add Train PostMapInitTest.cs
eafd1e9 
Add Train PostMapInitTest before i upload the map file this time
@Dunrab
initial train map file
ad7234a 
add the initial version of train before going in and adding fixes
@Dunrab
Initial train jobs file
bf95dc4 
Will need to tweak this further to match the amount of job spawns that are actually placed and make sure things like courier, anomaly and prisoner have job spawns
@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Map Changes any yml file in the Maps directories Changes: YML Changes any yml files labels Jan 11, 2025
@Floof-Station-Bot Floof-Station-Bot changed the title Map addition train Map Addition Train Jan 11, 2025
Dunrab added 5 commits January 11, 2025 17:11
@Dunrab
smaller evac shuttle
0afe28c 
swapped evac shuttle to be smaller so it can better fit in the sapce
@Dunrab
small map udpates
0dd054a 
added seb to epi
give parameds their hardsuit in their locker
changed the librarians door from service to librarian so they can open it
@Dunrab
add brigmed
2e5b0d7 
added a brigmed job slot
@Dunrab
added a Psychologis job slot
41cde55 
added a Psychologis job slot
@Dunrab
more updates to train
705a343 
renamed some warp points and added a few more
added a brigmed jobspawn and slightly larger room for them
added a psych office
added paper work templates to every department
some other misc changes
@Dunrab Dunrab marked this pull request as ready for review January 12, 2025 02:25
@github-actions github-actions bot added Status: Needs Review Someone please review this labels Jan 12, 2025
Dunrab added 2 commits January 11, 2025 21:32
@Dunrab
Forgot to change the mapPath
d4241a9 
Forgot to change the mapPath
@Dunrab
more clean up
1ac25d0 
seems i left a few wizden things in this file so had to remove them
@Dunrab
Copy link
Contributor Author

Dunrab commented Jan 12, 2025

should i add the map to the map pool, or is this one we leave to let admins forcemap?

@Memeji
Copy link
Collaborator

Memeji commented Jan 12, 2025

I myself am fine with it being in the map pool.
That's probably only cause I never played it before and I'm curious.

@FoxxoTrystan FoxxoTrystan added Priority: 2-Medium Needs to be resolved at some point Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team. labels Jan 12, 2025
Mnemotechnician
Mnemotechnician approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@Mnemotechnician Mnemotechnician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, yeah, never hurts to have another map to choose from.

@Dunrab
Copy link
Contributor Author

Dunrab commented Jan 12, 2025

will wait for more opinions before adding it to the pool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mnemotechnician Mnemotechnician Mnemotechnician approved these changes

@Memeji Memeji Memeji approved these changes

@Fansana Fansana Awaiting requested review from Fansana Fansana is a code owner

@FoxxoTrystan FoxxoTrystan Awaiting requested review from FoxxoTrystan FoxxoTrystan is a code owner

Assignees

@Dunrab Dunrab

Labels
Changes: C# Changes any cs files Changes: Map Changes any yml file in the Maps directories Changes: YML Changes any yml files Priority: 2-Medium Needs to be resolved at some point Status: Needs Review Someone please review this Undergoing Maintainer Discussion This PR is currently going through an internal discussion by the maintainer team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dunrab @Memeji @Mnemotechnician @FoxxoTrystan